bpo-45583: Correct 8000 datamodel.rst documentation of int() #29182
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
I confirm I just signed the CLA. |
|
I think it would also need to be backported to 3.8, since it was when the change was introduced. I see only 3.9 and 3.10 labels added |
There was a problem hiding this comment.
This is fine - it's a net improvement on what's already there. But at a nitpick level, it still reads as somewhat ambiguous to me: in the qualifier
if :meth:
__int__and :meth:__index__are not defined
it's not immediately clear whether it refers to the situation where neither of these is defined, or to the situation where they're not both defined. You could possibly tighten it up as:
if neither :meth:
__int__nor :meth:__index__is defined
Approving, since this is good to go as-is - the above is just a suggestion.
3.8 is in security-fix-only mode at this point, so we wouldn't normally backport docfixes to 3.8.
Unless @serhiy-storchaka objects, I think that's fine. @serhiy-storchaka has one or two other commits to his name. :-) |
It should be noted that this part of the documentation is redundant with function.rst's documentation of int. This one was correctly updated with Python 3.8
|
Thanks for the explanation. I admit that I'm just a Python user and didn't check the rules for what is ported or not to previous version. |
|
Thanks @Arthur-Milchior for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10. |
It should be noted that this part of the documentation is redundant with function.rst's documentation of int. This one was correctly updated with Python 3.8. (cherry picked from commit d9c1868) Co-authored-by: Arthur Milchior <arthur@milchior.fr>
|
GH-29285 is a backport of this pull request to the 3.10 branch. |
It should be noted that this part of the documentation is redundant with function.rst's documentation of int. This one was correctly updated with Python 3.8. (cherry picked from commit d9c1868) Co-authored-by: Arthur Milchior <arthur@milchior.fr>
|
GH-29286 is a backport of this pull request to the 3.9 branch. |
|
GH-29287 is a backport of this pull request to the 3.8 branch. |
) It should be noted that this part of the documentation is redundant with function.rst's documentation of int. This one was correctly updated with Python 3.8. (cherry picked from commit d9c1868) Co-authored-by: Arthur Milchior <arthur@milchior.fr>
) It should be noted that this part of the documentation is redundant with function.rst's documentation of int. This one was correctly updated with Python 3.8. (cherry picked from commit d9c1868) Co-authored-by: Arthur Milchior <arthur@milchior.fr>
) It should be noted that this part of the documentation is redundant with function.rst's documentation of int. This one was correctly updated with Python 3.8. (cherry picked from commit d9c1868) Co-authored-by: Arthur Milchior <arthur@milchior.fr>
bpo-45583: Correct datamodel.rst documentation of int()
It should be noted that this part of the documentation is redundant with
function.rst's documentation of int. This one was correctly updated with Python 3.8
https://bugs.python.org/issue45583