-
-
Notifications
You must be signed in to change notification settings - Fork 32k
bpo-45371: Fix distutils' rpath support for clang #28732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Christian Heimes <christian@python.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks, Christian.
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Signed-off-by: Christian Heimes <christian@python.org> (cherry picked from commit ef61960) Co-authored-by: Christian Heimes <christian@python.org>
GH-28733 is a backport of this pull request to the 3.10 branch. |
Signed-off-by: Christian Heimes <christian@python.org> (cherry picked from commit ef61960) Co-authored-by: Christian Heimes <christian@python.org>
GH-28734 is a backport of this pull request to the 3.9 branch. |
|
Hi @tiran, this fix seems hacky to me. distutils is deprecated and no longer synced externally, so it is not that problematic, but other fixes like this may still need to be issued and the incorrect Wouldn't this patch fix the issue? IMO, it does it in a much better way 😅 |
Please comment on the bpo ticket. I'll reopen it for you. |
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue45371
Automerge-Triggered-By: GH:tiran