8000 bpo-20853: fixed PDB's args and retval commands to handle objects with broken repr() by akulakov · Pull Request #28400 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-20853: fixed PDB's args and retval commands to handle objects with broken repr() #28400

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

bpo-20853: fixed PDB's args and retval commands to handle objects with broken repr() #28400

wants to merge 3 commits into from
+51 −3

Conversation

akulakov
Copy link
Contributor
@akulakov akulakov commented Sep 17, 2021 •
edited by bedevere-bot
Loading

Also expanded docs for retval cmd -- I found them confusing and insufficient when working on this issue.

https://bugs.python.org/issue20853

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Oct 18, 2021
@MaxwellDupre
Copy link
Contributor

I get:
./python -m test -vvv test_pdb
== CPython 3.11.0a5+ (heads/main:92a8fd08c7, Mar 1 2022, 17:51:16) [GCC 11.2.0]
== Linux-5.13.0-30-generic-x86_64-with-glibc2.34 little-endian
== cwd: /home/me/Documents/cpython/build/test_python_28417æ
== CPU count: 8
== encodings: locale=UTF-8, FS=utf-8
0:00:00 load avg: 0.94 Run tests sequentially
0:00:00 load avg: 0.94 [1/1] test_pdb
test test_pdb crashed -- Traceback (most recent call last):
File "/home/me/Documents/cpython/Lib/test/libregrtest/runtest.py", line 340, in _runtest_inner
refleak = _runtest_inner2(ns, test_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/me/Documents/cpython/Lib/test/libregrtest/runtest.py", line 280, in _runtest_inner2
the_module = importlib.import_module(abstest)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/me/Documents/cpython/Lib/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 1206, in _gcd_import
File "", line 1178, in _find_and_load
File "", line 1149, in _find_and_load_unlocked
File "", line 690, in _load_unlocked
File "", line 924, in exec_module
File "", line 241, in _call_with_frames_removed
File "/home/me/Documents/cpython/Lib/test/test_pdb.py", line 18, in
from test.test_doctest import _FakeInput
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/me/Documents/cpython/Lib/test/test_doctest.py", line 2816, in
if supports_unicode and not support.has_no_debug_ranges():
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/me/Documents/cpython/Lib/test/support/init.py", line 433, in has_no_debug_ranges
return bool(config['no_debug_ranges'])
~~~~~~^^^^^^^^^^^^^^^^^^^
KeyError: 'no_debug_ranges'

test_pdb failed (uncaught exception)

== Tests result: FAILURE ==

1 test failed:
test_pdb

Total duration: 205 ms
Tests result: FAILURE

@kumaraditya303 kumaraditya303 mentioned this pull request Jul 14, 2022
Closed
@jneb jneb mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akulakov @MaxwellDupre @the-knights-who-say-ni @ezio-melotti @bedevere-bot
0