bpo-45128: fixes
8000
test_multiprocessing_fork mysterious crash
#28387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe I can add some extra tests to catch this 🤔 |
|
I've created a bpo entry for this Windows build failures: https://bugs.python.org/issue45220 |
vstinner
reviewed
Sep 16, 2021
Misc/NEWS.d/next/Tests/2021-09-16-17-22-35.bpo-45128.Jz6fl2.rst
Outdated
Show resolved
Hide resolved
vstinner
reviewed
Sep 16, 2021
vstinner
reviewed
Sep 16, 2021
Misc/NEWS.d/next/Tests/2021-09-16-17-22-35.bpo-45128.Jz6fl2.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Victor Stinner <vstinner@python.org>
dced204 to
a48afcb
Compare
|
Rebased ♻️ |
pablogsal
approved these changes
Sep 19, 2021
|
Thanks a lot for the fix @sobolevn! Does this need to be backported to something before 3.10? |
|
Thanks @sobolevn for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 19, 2021
|
GH-28462 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 19, 2021
(cherry picked from commit 1d42408) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
pablogsal
pushed a commit
that referenced
this pull request
Sep 19, 2021
(cherry picked from commit 1d42408) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
Thanks, everyone! @pablogsal no, this test does not exist in 3.9 |
niyas-sait
pushed a commit
to niyas-sait/cpython
that referenced
this pull request
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several thoughts on this:
test_shared_memory_basicstest #28182 (comment)https://bugs.python.org/issue45128