8000 [3.3] bpo-22928: Disabled HTTP header injections in http.client. by serhiy-storchaka · Pull Request #2817 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.3] bpo-22928: Disabled HTTP header injections in http.client. #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2017
Merged

[3.3] bpo-22928: Disabled HTTP header injections in http.client. #2817

merged 2 commits into from
Jul 26, 2017

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Jul 22, 2017 •
edited by bedevere-bot
Loading

Original patch by Demian Brecht.
(cherry picked from commit a112a8a)

https://bugs.python.org/issue22928

@serhiy-storchaka
[3.3] Issue pythonGH-22928: Disabled HTTP header injections in http.c…
720362c 
…lient.

Original patch by Demian Brecht..
(cherry picked from commit a112a8a)
@serhiy-storchaka serhiy-storchaka added the type-security A security issue label Jul 22, 2017
@mention-bot
Copy link

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pitrou, @gvanrossum and @orsenthil to be potential reviewers.

@vstinner vstinner mentioned this pull request Jul 25, 2017
Closed
@vstinner
Copy link
Member

See my comment on the bpo: http://bugs.python.org/issue22928#msg299053

vstinner
vstinner reviewed Jul 25, 2017
View reviewed changes
Lib/http/client.py

# the patterns for both name and value are more leniant than RFC
# definitions to allow for backwards compatibility
_is_legal_header_name = re.compile(rb'[^:\s][^:\r\n]*\Z').match
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 2.7 regex starts with \A. Is it useful?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. match() always matches from the start.

vstinner
vstinner approved these changes Jul 25, 2017
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ned-deily ned-deily merged commit 8e88f6b into python:3.3 Jul 26, 2017
@serhiy-storchaka serhiy-storchaka deleted the backport-a112a8a-3.3 branch August 9, 2017 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @mention-bot @vstinner @ned-deily @the-knights-who-say-ni
0