8000 bpo-45018: Fix rangeiter_reduce in rangeobject.c by chilaxan · Pull Request #27938 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-45018: Fix rangeiter_reduce in rangeobject.c #27938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 7 commits into from
Aug 27, 2021
Merged

bpo-45018: Fix rangeiter_reduce in rangeobject.c #27938

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dffa24e
Fix rangeiter_reduce in rangeobject.c
chilaxan Aug 25, 2021
c880127
Add tests
ambv Aug 26, 2021
bf3f944
Add test for overflowing integer range index
ambv Aug 26, 2021
e29696e
add Blurb
ambv Aug 26, 2021
2df7177
Use a shorter test per Serhiy's review
ambv Aug 26, 2021
7241068
Confirm __setstate__ worked by checking __reduce__
ambv Aug 26, 2021
2d57834
I got overly excited with the additional asserts 🤦
ambv Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
I got overly excited with the additional asserts 🤦
  • Loading branch information
@ambv
ambv committed Aug 26, 2021
commit 2d5783485bab25c58a95248ec035fe7f6d610fb5
2 changes: 1 addition & 1 deletion Lib/test/test_range.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ def test_iterator_pickling_overflowing_index(self):
self.assertEqual(idx, 0)
it.__setstate__(2**32 + 1) # undocumented way to set r->index
_, _, idx = it.__reduce__()
self.assertEqual(idx, 2**32)
self.assertEqual(idx, 2**32 + 1)
d = pickle.dumps(it, proto)
it = pickle.loads(d)
self.assertEqual(next(it), 2**32 + 1)
Expand Down
0