10000
bpo-44990: Change layout of evaluation frames. "Layout B" #27933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now at a fixed offset in the frame.
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit dbad8a1 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
The failure on buildbot/AMD64 Arch Linux Asan Debug PR is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the layout of evaluation frames from:
to:
(Higher addresses at top)
Which is how the old frame object was laid out (at least after the "block stack" was removed).
This simplifies the code and is generally less surprising to the reader (locals is now a constant positive offset from the frame pointer, not a computed negative offset).
It is no slower, in fact it is about 1% faster
https://bugs.python.org/issue44990