8000 bpo-44975: [typing] Support issubclass for ClassVar data members by Fidget-Spinner · Pull Request #27883 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-44975: [typing] Support issubclass for ClassVar data members #27883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

bpo-44975: [typing] Support issubclass for ClassVar data members #27883

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a613af6
Support issubclass for ClassVar data members
Fidget-Spinner Aug 22, 2021
f045d2e
make it work with string annotations and PEP 563
Fidget-Spinner Aug 23, 2021
58c69e1
Apply Lukasz' suggestions
Fidget-Spinner Aug 24, 2021
2ed2ee5
fix test
Fidget-Spinner Aug 24, 2021
c842370
Use identity check instead of equality
Fidget-Spinner Aug 26, 2021
f44d3b6
Merge remote-tracking branch 'upstream/main' into issubclass_data_pro…
Fidget-Spinner Dec 5, 2021
9278a34
fix merge issues
Fidget-Spinner Dec 5, 2021
ba57bb1
Add more tests and comments
Fidget-Spinner Dec 5, 2021
43ec2ea
support value checking classvars
Fidget-Spinner Dec 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use identity check instead of equality 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
  • Loading branch information
@Fidget-Spinner @ambv
Fidget-Spinner and ambv authored Aug 26, 2021
commit c8423705307ee8a7242850afc7fee698329ddf9a
2 changes: 1 addition & 1 deletion Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1405,7 +1405,7 @@ def _is_callable_or_classvar_members_only(cls):
if callable(attr):
continue
annotation = annotations.get(attr_name)
if getattr(annotation, '__name__', None) == 'ClassVar':
if getattr(annotation, '__origin__', None) is ClassVar:
continue
# String annotations (forward references).
if isinstance(annotation, str) and annotation.startswith(_classvar_prefixes):
Expand Down
0