Fix reST markup in dataclasses.rst #27843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature of field() had an extraneous colon at the end, causing it to appear all bold and without the module name.
|
Thanks @jean-abou-samra for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-27845 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 19, 2021
The signature of field() had an extraneous colon at the end, causing it to appear all bold and without the module name. (cherry picked from commit d26dbba) Co-authored-by: Jean-Abou-Samra <37271310+Jean-Abou-Samra@users.noreply.github.com>
ericvsmith
pushed a commit
that referenced
this pull request
Aug 19, 2021
The signature of field() had an extraneous colon at the end, causing it to appear all bold and without the module name. (cherry picked from commit d26dbba) Co-authored-by: Jean-Abou-Samra <37271310+Jean-Abou-Samra@users.noreply.github.com> Co-authored-by: Jean-Abou-Samra <37271310+Jean-Abou-Samra@users.noreply.github.com>
|
Good catch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of field() had an extraneous colon at the end, causing it
to appear all bold and without the module name.
[The problematic signature can be seen by scrolling a bit at https://docs.python.org/3.10/library/dataclasses.html#dataclasses.dataclass.]