8000 bpo-42560: add warning to Tkinter docs about outdated pre-8.5 documentation online by roseman · Pull Request #27836 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-42560: add warning to Tkinter docs about outdated pre-8.5 documentation online #27836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 23, 2021
Merged

bpo-42560: add warning to Tkinter docs about outdated pre-8.5 documentation online #27836

merged 4 commits into from
Aug 23, 2021

Conversation

roseman
Copy link
Contributor
@roseman roseman commented Aug 19, 2021 •
edited by bedevere-bot
Loading

As this is just before the section talking about external resources (which we effectively depend on at present, as our own documentation is limited), I feel it's very much worth mentioning that so much of what is available is out of date.

https://bugs.python.org/issue42560

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Aug 19, 2021
E-Paine
E-Paine reviewed Aug 21, 2021
View reviewed changes
ambv
ambv approved these changes Aug 23, 2021
View reviewed changes
ambv and others added 3 commits August 23, 2021 20:40
@ambv @E-Paine
Fix typo
b72cbf6 
Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
@ambv
Downgrade warning to note
8ba9f93
@ambv
Tone down language
0ec6bfc
@ambv ambv added skip news needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Aug 23, 2021
@ambv ambv merged commit 1eb4510 into python:main Aug 23, 2021
@miss-islington
Copy link
Contributor

Thanks @roseman for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2021
@roseman @miss-islington
bpo-42560: add warning to Tkinter docs about outdated pre-8.5 documen…
c5223fa 
…tation online (pythonGH-27836)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
(cherry picked from commit 1eb4510)

Co-authored-by: Mark Roseman <mark@markroseman.com>
@miss-islington
Copy link
Contributor

Sorry, @roseman and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1eb451031a64b4f28d737ee7f394252ae9a76118 3.9

@bedevere-bot
Copy link

GH-27915 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 23, 2021
@ambv ambv removed the needs backport to 3.9 only security fixes label Aug 23, 2021
miss-islington added a commit that referenced this pull request Aug 23, 2021
@miss-islington @roseman
bpo-42560: add warning to Tkinter docs about outdated pre-8.5 documen…
8351df6 
…tation online (GH-27836)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
(cherry picked from commit 1eb4510)

Co-authored-by: Mark Roseman <mark@markroseman.com>
@hpmason hpmason mannequin mentioned this pull request Nov 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@E-Paine E-Paine E-Paine left review comments

@ambv ambv ambv approved these changes

Assignees

@ambv ambv

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@roseman @miss-islington @bedevere-bot @ambv @E-Paine @the-knights-who-say-ni
0