-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
bpo-44698: Restore complex pow behaviour for small integral exponents #27772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mdickinson
merged 8 commits into
python:main
from
mdickinson:fix/restore-complex-pow-integer-check
Aug 17, 2021
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4b0564b
Restore the old check for integer exponent
mdickinson 8895a6a
Add regression test
mdickinson 8f557fa
News entry
mdickinson a925b1c
Remove unused variable
mdickinson c03c9a5
Use 'floor' rather than 'rint', just in case there are platforms that…
mdickinson 6ac2785
More comprehensive tests
mdickinson b0babe9
Put new tests into their own method
mdickinson a74c34e
Remove unnecessary local variable; restore comment
mdickinson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Core and Builtins/2021-08-15-10-39-06.bpo-44698.lITKNc.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Restore behaviour of complex exponentiation with integer-valued exponent of | ||
type :class:`float` or :class:`complex`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -172,14 +172,7 @@ c_powu(Py_complex x, long n) | |
static Py_complex | ||
c_powi(Py_complex x, long n) | ||
{ | ||
Py_complex cn; | ||
|
||
if (n > 100 || n < -100) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This branch is now redundant: the bounds check is performed in the code that calls |
||
cn.real = (double) n; | ||
cn.imag = 0.; | ||
return _Py_c_pow(x,cn); | ||
} | ||
else if (n > 0) | ||
if (n > 0) | ||
return c_powu(x,n); | ||
else | ||
return _Py_c_quot(c_1, c_powu(x,-n)); | ||
|
@@ -523,19 +516,12 @@ complex_pow(PyObject *v, PyObject *w, PyObject *z) | |
return NULL; | ||
} | ||
errno = 0; | ||
// Check if w is an integer value that fits inside a C long, so we can | ||
// use a faster algorithm. TO_COMPLEX(w, b), above, already handled the | ||
// conversion from larger longs, as well as other types. | ||
if (PyLong_Check(w)) { | ||
int overflow = 0; | ||
long int_exponent = PyLong_AsLongAndOverflow(w, &overflow); | ||
if (int_exponent == -1 && PyErr_Occurred()) | ||
return NULL; | ||
if (overflow == 0) | ||
p = c_powi(a, int_exponent); | ||
else | ||
p = _Py_c_pow(a, b); | ||
} else { | ||
// Check whether the exponent has a small integer value, and if so use | ||
// a faster and more accurate algorithm. | ||
if (b.imag == 0.0 && b.real == floor(b.real) && fabs(b.real) <= 100.0) { | ||
p = c_powi(a, (long)b.real); | ||
} | ||
else { | ||
p = _Py_c_pow(a, b); | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.