8000 bpo-44865: Missing translations in `argparse` by jdetrey · Pull Request #27668 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-44865: Missing translations in argparse #27668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2024
Merged

bpo-44865: Missing translations in argparse #27668

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
741edc3
bpo-44865: Missing translations in argparse
jdetrey Aug 8, 2021
6e7a277
bpo-44865: Add NEWS entry
jdetrey Aug 24, 2021
c9cfada
Merge branch 'main' into fix-44865
jdetrey Feb 26, 2024
55c82f4
bpo-44865: Update NEWS entry
jdetrey Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Lib/argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,8 @@ def format_help(self):
# add the heading if the section was non-empty
if self.heading is not SUPPRESS and self.heading is not None:
current_indent = self.formatter._current_indent
heading = '%*s%s:\n' % (current_indent, '', self.heading)
heading_text = _('%(heading)s:') % dict(heading=self.heading)
heading = '%*s%s\n' % (current_indent, '', heading_text)
else:
heading = ''

Expand Down Expand Up @@ -748,7 +749,7 @@ def __str__(self):
if self.argument_name is None:
format = '%(message)s'
else:
format = 'argument %(argument_name)s: %(message)s'
format = _('argument %(argument_name)s: %(message)s')
return format % dict(message=self.message,
argument_name=self.argument_name)

Expand Down Expand Up @@ -876,7 +877,7 @@ def __init__(self,
_option_strings.append(option_string)

if help is not None and default is not None:
help += f" (default: {default})"
help += _(' (default: %(default)s)')

super().__init__(
option_strings=_option_strings,
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2021-08-24-20-47-37.bpo-44865.c3BhZS.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add missing calls to localization function in :mod:`argparse`.
0