-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-63416: Speed up assertEqual on long sequences #27434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
20fde31
Fix bpo-19217
eamanu 6996d8a
fix unnecessary space and solve @gpshead comments
eamanu adfcf6d
fix test
ddebcfa
Merge remote-tracking branch 'temp/fix_bpo-19217' into bpo-19217-slow…
jdevries3133 81900d4
bpo-19217: fix failing test in unittest's test suite
jdevries3133 e5cb7bc
bpo-19217: add blurb
jdevries3133 6955d81
revert changes to difflib.py
jdevries3133 46f5e29
add regression test
jdevries3133 847bfc4
Merge branch 'main' of github.com:python/cpython into bpo-19217-slow-…
jdevries3133 856029d
draft implementation of unittest.case._heuristic_diff
jdevries3133 1dd1bcd
fix: remove now-unused imports from test_case.py
jdevries3133 1f45b28
merge upstream python/cpython:main
jdevries3133 988740a
add variably scaled test cases, misc updates & revisions
jdevries3133 4661f75
move Test_HeuristicDiff beneath main tests
jdevries3133 a9d23c4
remove unnecessary list comprehension in Lib/unittest/case.py
jdevries3133 192d7a4
spelling error in Lib/unittest/test/test_case.py
jdevries3133 74895e9
implement second review from @ambv
jdevries3133 e21dbe3
merge changes from PR suggestions
jdevries3133 5e8a186
Merge branch 'main' of github.com:python/cpython into bpo-19217-slow-…
jdevries3133 28cb042
fix from @JelleZijlstra
jdevries3133 63ecc45
fix from @JelleZijlstra
jdevries3133 e4344cb
remove unnecessary type checker supression
jdevries3133 0bdf06c
fix typo
jdevries3133 05ffdf2
simplify tuple syntax
jdevries3133 5767d21
fix news entry "~lists~ => sequenecs"
jdevries3133 b9f2f9d
better document the reasoning behind the heuristic
jdevries3133 5351506
thanks @JelleZijlstra
jdevries3133 872de08
thanks @JelleZijlstra
jdevries3133 180c732
fix whitespace around keyword argument
jdevries3133 200a1a7
Merge branch 'bpo-19217-slow-assertEq' of github.com:jdevries3133/cpy…
jdevries3133 fc752cf
update blurb to describe observable changes
jdevries3133 b53738f
Merge branch 'main' of github.com:python/cpython into bpo-19217-slow-…
jdevries3133 adc7d6f
reword to make less promises
gpshead c4d6f38
Merge branch 'main' of github.com:python/cpython into bpo-19217-slow-…
jdevries3133 9e6a464
Merge branch 'bpo-19217-slow-assertEq' of github.com:jdevries3133/cpy…
jdevries3133 0ad029f
Merge remote-tracking branch 'upstream/main' into bpo-19217-slow-asse…
AA-Turner 4c5175c
Remove annotations
AA-Turner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
Misc/NEWS.d/next/Library/2021-07-21-22-57-51.bpo-19217.vm-cr-.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
Optimize unittest.TestCase.assertEqual method for long sequences of varied | ||
Optimize :meth:`~unittest.TestCase.assertEqual` method for long sequences of varied | ||
items. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.