8000 bpo-44717: improve AttributeError on circular imports of submodules by FFY00 · Pull Request #27338 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-44717: improve AttributeError on circular imports of submodules #27338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 24, 2021
Merged

bpo-44717: improve AttributeError on circular imports of submodules #27338

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ae2f5a
bpo-44717: improve AttributeError on circular imports of submodules
FFY00 Jul 23, 2021
96b8cd9
Simplify submodule tracking code
ambv Jul 23, 2021
8e95aab
Always set `uninitialized_submodules`
ambv Jul 23, 2021
9855484
Regen importlib.h
ambv Jul 23, 2021
793198c
fix _uninitialized_submodules and improve _PyModuleSpec_IsUninitializ…
FFY00 Jul 23, 2021
4a3f002
Reword comment
ambv Jul 24, 2021
c890c3e
add new test data to the makefile
FFY00 Jul 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reword comment
  • Loading branch information
@ambv
ambv committed Jul 24, 2021
commit 4a3f002f999617e77466c0cb7dcf9ce885219379
2 changes: 1 addition & 1 deletion Lib/importlib/_bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,7 +1008,7 @@ def _find_and_load_unlocked(name, import_):
raise ModuleNotFoundError(_ERR_MSG.format(name), name=name)
else:
if parent_spec:
# Temporarily add currently child we are going to import to parent's
# Temporarily add child we are currently importing to parent's
# _uninitialized_submodules for circular import tracking.
parent_spec._uninitialized_submodules.append(child)
try:
Expand Down
0