8000 bpo-44717: improve AttributeError on circular imports of submodules by FFY00 · Pull Request #27338 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@FFY00
Copy link
Member
@FFY00 FFY00 commented Jul 24, 2021

#27299 was missing the new test data in the makefile. The build bot failed because the tests are installed to the system and run from there.

https://bugs.python.org/issue44717

@FFY00 FFY00 requested review from ambv and pablogsal July 24, 2021 18:23
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 24, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit c890c3e 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 24, 2021
Copy link
Member
@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @FFY00 for the investigation and the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0