bpo-30937: Make usage of newline='' consistent in csv documentation #2730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ammaraskar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @bitdancer and @berkerpeksag to be potential reviewers. |
daxlab
approved these changes
Jul 16, 2017
berkerpeksag
approved these changes
Oct 26, 2017
|
Thanks @ammaraskar for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 26, 2017
|
GH-4129 is a backport of this pull request to the 3.6 branch. |
|
Thanks, Ammar! |
berkerpeksag
pushed a commit
that referenced
this pull request
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newline comment was added as part of 9188702
bpo issue: https://bugs.python.org/issue7198
but looks like when the
DictReaderandDictWriterdocumentation was added, this was overlooked. Note these classes use a simple csv.writer/reader function underneath so they potentially have the same problems with quoted fields and embedded newlines.