[3.4] bpo-26617: Ensure gc tracking is off when invoking weakref callbacks. #2695
Conversation
…backs. (cherry picked from commit 8f657c3)
146b25d to
ad0aab6
Compare
Misc/NEWS
Outdated
| @@ -10,6 +10,8 @@ Release date: XXXX-XX-XX | |||
| Core and Builtins | |||
| ----------------- | |||
|
|
|||
| - Issue #26617: Fix crash when GC runs during weakref callbacks. | |||
There was a problem hiding this comment.
You may rewrite this as a NEWS.d entry with blurb, to prevent conflicts.
There was a problem hiding this comment.
Yes, please do this.
There was a problem hiding this comment.
I tried to use blurb, entered all data, but it doesn't have any effect.
There was a problem hiding this comment.
If you ran blurb and entered data, and it didn't print an error, then it had an effect. It creates a file in Misc/NEWS.d/next and runs "git add" on that file.
Were you inside this repo when you ran it?
If it's more convenient, you could copy an existing file in Misc/NEWS.d/next and manually change the filename to match the current time. But we should figure out why blurb isn't working for you.
There was a problem hiding this comment.
Ah, this is my fault! Sorry. I executed git diff and git log, but their didn't show any changes. I needed to use git diff --staged or git status instead.
|
You might wait for my PR #2475 to be merged to get a CI on 3.4 ;-) |
|
Thanks for the backport! |
(cherry picked from commit 8f657c3)