8000 bpo-24132: Add direct subclassing of PurePath/Path in pathlib by kfollstad · Pull Request #26906 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-24132: Add direct subclassing of PurePath/Path in pathlib #26906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

bpo-24132: Add direct subclassing of PurePath/Path in pathlib #26906

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
710f577
bpo-24132: Add tests for class properties in pathlib's PurePath/Path
kfollstad Jun 11, 2021
a373969
bpo-24132: Add test for direct subclassing of PurePath/Path in pathlib
kfollstad Jun 14, 2021
35d8f78
bpo-24132: Fix inconsistent organization of is_mount in pathlib
kfollstad May 27, 2021
bab67b4
bpo-24132: Replace additional hardcoded references in pathlib
kfollstad May 3, 2021
67faae0
bpo-24132: Replace factory functionality with masquerade in pathlib
kfollstad Jun 14, 2021
610f41e
bpo-24132: Add tests for comparing subclasses of PurePath in pathlib
kfollstad Jun 17, 2021
a0c4998
bpo-24132: Document direct subclassing of PurePath/Path in pathlib
kfollstad Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-24132: Fix inconsistent organization of is_mount in pathlib 
Existing is_mount method in Path was Posix only and not cross-
platform even though it was in a cross-platform base class. The existing
design relied upon being overriden later in WindowsPath. Consolidated
code from both into new Path.is_mount() which is now cross-plaform
similiar to all of the other Path methods.
  • Loading branch information
@kfollstad
kfollstad committed Jun 24, 2021
commit 35d8f789fad64674a7c7d254f2d5808049f0e504
6 changes: 3 additions & 3 deletions Lib/pathlib.py
8AEC
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1322,6 +1322,9 @@ def is_mount(self):
"""
Check if this path is a POSIX mount point
"""
if os.name != "posix":
raise NotImplementedError("Path.is_mount() is "
"unsupported on this system")
# Need to exist and be a dir
if not self.exists() or not self.is_dir():
return False
Expand Down Expand Up @@ -1444,6 +1447,3 @@ class WindowsPath(Path, PureWindowsPath):
On a Windows system, instantiating a Path should return this object.
"""
__slots__ = ()

def is_mount(self):
raise NotImplementedError("Path.is_mount() is unsupported on this system")
0