8000 bpo-43693: Turn localspluskinds into an object by gvanrossum · Pull Request #26749 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-43693: Turn localspluskinds into an object #26749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 21, 2021
Merged

bpo-43693: Turn localspluskinds into an object #26749

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
da37894
Make co_localspluskinds an object instead of a raw pointer
gvanrossum Jun 15, 2021
7564dbe
Regenerate frozen files
gvanrossum Jun 15, 2021
32cc42e
Use PyBytes_AsString instead of PyBytes_AS_STRING
gvanrossum Jun 15, 2021
9e54613
Fix refcnt bug; tighten checks; regen importlib
gvanrossum Jun 15, 2021
e5b413e
Regenerate more frozen things
gvanrossum Jun 15, 2021
00954ec
Merge main (esp. Eric's PR)
gvanrossum Jun 15, 2021
4fba934
Tweaks I noticed while reviewing this myself
gvanrossum Jun 15, 2021
ebaaeca
Fix PyCode_NewEmpty()
gvanrossum Jun 15, 2021
b09738c
Fix test_ctypes (marshalled code size changed)
gvanrossum Jun 16, 2021
703727c
Tweak things noted in code review
gvanrossum Jun 18, 2021
a64057a
Make symbol static
gvanrossum Jun 18, 2021
0ff4466
Merge main at 06cda808f149fae9b4c688f752b6eccd0d455ba4
gvanrossum Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use PyBytes_AsString instead of PyBytes_AS_STRING 
(But still I get a crash in _freeze_importlib)
  • Loading branch information
@gvanrossum
gvanrossum committed Jun 15, 2021
commit 32cc42e34b57d05a1e634fbeeb7de934569ce381
4 changes: 2 additions & 2 deletions Include/internal/pycore_code.h
8502
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,13 +192,13 @@ typedef unsigned char _PyLocals_Kind;
static inline _PyLocals_Kind
_PyLocals_GetKind(PyObject *kinds, int i)
{
return ((_PyLocals_Kind *)PyBytes_AS_STRING(kinds))[i];
return ((_PyLocals_Kind *)PyBytes_AsString(kinds))[i];
}

static inline void
_PyLocals_SetKind(PyObject *kinds, int i, _PyLocals_Kind kind)
{
((_PyLocals_Kind *)PyBytes_AS_STRING(kinds))[i] = kind;
((_PyLocals_Kind *)PyBytes_AsString(kinds))[i] = kind;
}


Expand Down
0