8000 bpo-44405: make dis cli "official" by CCLDArjun · Pull Request #26714 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

bpo-44405: make dis cli "official" #26714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

CCLDArjun
Copy link
Contributor
@CCLDArjun CCLDArjun commented Jun 13, 2021

@@ -566,7 +566,7 @@ def dis(self):
return output.getvalue()


def _test():
def main():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't change the name of the function.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm just read the comments on bpo about change this name :)

@@ -41,6 +41,10 @@ the following command can be used to display the disassembly of

(The "2" is a line number).

:mod:`dis` an also be invoked as a script to disassemble other scripts. For example::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take care the page width (79 chars, if I'm not wrong)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more detail about the args (infile)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it seems pretty straightforward. What more to explain other than feed it a python script?

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 19, 2021
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 9, 2022
@CCLDArjun CCLDArjun closed this Jul 12, 2023
@CCLDArjun CCLDArjun deleted the bpo-44405a branch July 12, 2023 16:14
@hugovk
Copy link
Member
hugovk commented Sep 3, 2023

New issue for documenting the CLI: #108826

And PR: #108827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0