-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-44405: make dis cli "official" #26714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -566,7 +566,7 @@ def dis(self): | |||
return output.getvalue() | |||
|
|||
|
|||
def _test(): | |||
def main(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't change the name of the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I'm just read the comments on bpo about change this name :)
@@ -41,6 +41,10 @@ the following command can be used to display the disassembly of | |||
|
|||
(The "2" is a line number). | |||
|
|||
:mod:`dis` an also be invoked as a script to disassemble other scripts. For example:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
take care the page width (79 chars, if I'm not wrong)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add more detail about the args (infile)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, it seems pretty straightforward. What more to explain other than feed it a python script?
This PR is stale because it has been open for 30 days with no activity. |
https://bugs.python.org/issue44405