8000 bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag by erlend-aasland · Pull Request #26680 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag #26680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2021
Merged

bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag #26680

merged 1 commit into from
Jun 12, 2021

Conversation

erlend-aasland
Copy link
Contributor
@erlend-aasland erlend-aasland commented Jun 11, 2021 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland requested a review from tiran June 11, 2021 18:43
nanjekyejoannah
nanjekyejoannah approved these changes Jun 12, 2021
View reviewed changes
Copy link
Contributor
@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, @tiran can confirm on this.

@erlend-aasland
Copy link
Contributor Author

Thanks for reviewing, @nanjekyejoannah! I figure this is just a copy-and-paste error.

nanjekyejoannah
nanjekyejoannah reviewed Jun 12, 2021
View reviewed changes
Copy link
Contributor
@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let me merge this. Christian can complain, if it was not meant to be.

@nanjekyejoannah nanjekyejoannah merged commit cb7230c into python:main Jun 12, 2021
@erlend-aasland erlend-aasland deleted the remove-duplicate-ssl-flag branch June 12, 2021 20:18
@tiran tiran added the needs backport to 3.10 only security fixes label Jun 13, 2021
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2021
@miss-islington
bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag (pythonGH-26680)
82a43de 
(cherry picked from commit cb7230c)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 13, 2021
@bedevere-bot
Copy link

GH-26704 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Jun 13, 2021
@miss-islington
bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag (GH-26680)
f30f484 
(cherry picked from commit cb7230c)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
jdevries3133 pushed a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
@jdevries3133
bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag (pythonGH-26680)
732ecab
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erlend-aasland @miss-islington @bedevere-bot @nanjekyejoannah @tiran @the-knights-who-say-ni
0