8000 bpo-44335: Fix a regression when identifying invalid characters in syntax errors by pablogsal · Pull Request #26589 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-44335: Fix a regression when identifying invalid characters in syntax errors #26589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2021
Merged

bpo-44335: Fix a regression when identifying invalid characters in syntax errors #26589

merged 1 commit into from
Jun 8, 2021

Conversation

pablogsal
Copy link
Member
@pablogsal pablogsal commented Jun 8, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from lysnikolaou as a code owner June 8, 2021 00:14
lysnikolaou
lysnikolaou approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member
@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@pablogsal pablogsal merged commit d334c73 into python:main Jun 8, 2021
@pablogsal pablogsal deleted the bpo-44335 branch June 8, 2021 11:25
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2021
@pablogsal @miss-islington
bpo-44335: Fix a regression when identifying invalid characters in sy…
4dba3b8 
…ntax errors (pythonGH-26589)

(cherry picked from commit d334c73)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

GH-26600 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 8, 2021
miss-islington added a commit that referenced this pull request Jun 8, 2021
@miss-islington @pablogsal
bpo-44335: Fix a regression when identifying invalid characters in sy…
933b5b6 
…ntax errors (GH-26589)

(cherry picked from commit d334c73)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.10 has failed when building commit 933b5b6.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/696/builds/110) and take a look at the build logs.
  4. Check if the failure is related to this commit (933b5b6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/696/builds/110

Summary of the results of the build (if available):

Click to see traceback logs 
fatal: unable to access 'https://github.com/python/cpython.git/': Couldn't resolve host 'github.com'

chmod: cannot access 'target/': No such file or directory

make: *** No rule to make target 'distclean'.  Stop.

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @miss-islington @bedevere-bot @lysnikolaou @the-knights-who-say-ni
0