8000 [3.10] bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows (GH-26502) by miss-islington · Pull Request #26518 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.10] bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows (GH-26502) #26518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2021
Merged

[3.10] bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows (GH-26502) #26518

merged 1 commit into from
Jun 3, 2021

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Jun 3, 2021 •
edited by bedevere-bot
Loading

Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False,
since read() can raise ssl.SSLEOFError on Windows.
(cherry picked from commit ea0210f)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue43921

@vstinner @miss-islington
bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows (pythonGH-…
9284d4b 
…26502)

Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False,
since read() can raise ssl.SSLEOFError on Windows.
(cherry picked from commit ea0210f)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington miss-islington requested a review from tiran as a code owner June 3, 2021 16:10
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request Jun 3, 2021
Merged
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jun 3, 2021
vstinner
vstinner approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner vstinner merged commit d2ab15f into python:3.10 Jun 3, 2021
@miss-islington miss-islington deleted the backport-ea0210f-3.10 branch June 3, 2021 20:15
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot
0