bpo-43921: Fix test_ssl.test_pha_required_nocert() #26489
Conversation
Fix test_pha_required_nocert() of test_ssl: catch two more EOF cases (when the recv() method returns an empty string).
|
Without this change, With this change, the command didn't fail, I ran it for like 30 minutes. |
|
cc @tiran @pablogsal: I plan to merge this fix tomorrow, test_ssl random failures are super annoying, and I'm sure that this change fix the issue (I ran a functional test, see my previous comment). |
|
LGTM, although it's more of a patch than a proper fix. The test connection should not fail with an EOF error. There is some foul play. It's good enough for me. |
I don't have the bandwidth to investigate that. I'm just an employee who like to see a green CI. The EOF check was already there before my change :-p |
|
If someone wants to enhance the test, I would suggest to check for TLS alerts, rather than checking how the client socket fails or how it's closed. |
|
Come on little bot, you can do it! I believe in you! |
|
@miss-islington: knock knock knock |
|
The backport PR is not created automatically :-( python/miss-islington#462 |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-26494 is a backport of this pull request to the 3.10 branch. |
Fix test_pha_required_nocert() of test_ssl: catch two more EOF cases (when the recv() method returns an empty string). (cherry picked from commit 320eaa7) Co-authored-by: Victor Stinner <vstinner@python.org>
Fix test_pha_required_nocert() of test_ssl: catch two more EOF cases
(when the recv() method returns an empty string).
https://bugs.python.org/issue43921