bpo-44285: Assert that the env_file variable in getpath.c is NULL during an error check #26486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing an error check
vstinner
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
LGTM. The assertion is correct. I wrote this code ;-)
I cannot say it fix https://bugs.python.org/issue44285 I trust you ;-)
|
Backports would be nice as well, but not necessary. |
|
I created https://bugs.python.org/issue44290 |
|
Thanks @stratakis for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Thanks @stratakis for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-26495 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 2, 2021
…eck (pythonGH-26486) This was flagged by a static analyzer, but the logic of why this is NULL on error is hard to follow for humans as well. (cherry picked from commit bdb5690) Co-authored-by: stratakis <cstratak@redhat.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 2, 2021
…eck (pythonGH-26486) This was flagged by a static analyzer, but the logic of why this is NULL on error is hard to follow for humans as well. (cherry picked from commit bdb5690) Co-authored-by: stratakis <cstratak@redhat.com>
|
GH-26496 is a backport of this pull request to the 3.9 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44285