8000 [3.10] bpo-44263: Fix _decimal and _testcapi GC protocol (GH-26464) by miss-islington · Pull Request #26465 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.10] bpo-44263: Fix _decimal and _testcapi GC protocol (GH-26464) #26465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2021
Merged

[3.10] bpo-44263: Fix _decimal and _testcapi GC protocol (GH-26464) #26465

merged 1 commit into from
May 31, 2021

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented May 31, 2021 •
edited by bedevere-bot
Loading
  • _testcapi.heapgctype: implement a traverse function since the type
    is defined with Py_TPFLAGS_HAVE_GC.
  • _decimal: PyDecSignalDictMixin_Type is no longer defined with
    Py_TPFLAGS_HAVE_GC since it has no traverse function.
    (cherry picked from commit 142e5c5)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue44263

@vstinner @miss-islington
bpo-44263: Fix _decimal and _testcapi GC protocol (pythonGH-26464)
08e8e70 
* _testcapi.heapgctype: implement a traverse function since the type
  is defined with Py_TPFLAGS_HAVE_GC.
* _decimal: PyDecSignalDictMixin_Type is no longer defined with
  Py_TPFLAGS_HAVE_GC since it has no traverse function.
(cherry picked from commit 142e5c5)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request May 31, 2021
Merged
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

vstinner
vstinner approved these changes May 31, 2021
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@pablogsal pablogsal merged commit 7fe9cad into python:3.10 May 31, 2021
@miss-islington miss-islington deleted the backport-142e5c5-3.10 branch May 31, 2021 11:25
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@pablogsal pablogsal mentioned this pull request May 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @vstinner @pablogsal @the-knights-who-say-ni @bedevere-bot
0