8000 bpo-42972: Fully support GC for _winapi.Overlapped by Fidget-Spinner · Pull Request #26381 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-42972: Fully support GC for _winapi.Overlapped #26381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2021
Merged

bpo-42972: Fully support GC for _winapi.Overlapped #26381

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0fa0217
tp_traverse for _winapi.Overlapped
Fidget-Spinner May 26, 2021
9f3ca36
GC track the object
Fidget-Spinner May 26, 2021
96f0d0e
move untrack down to a safer place
Fidget-Spinner May 26, 2021
0493de0
add module m_traverse, clear, free - fully implement the GC protocol …
Fidget-Spinner May 26, 2021
fc3e774
static int -> static void
Fidget-Spinner May 26, 2021
78113cc
Apply victor's suggestions
Fidget-Spinner May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply victor's suggestions
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed May 27, 2021
commit 78113ccdb6e96dac11757823a30bf7bf72076acb
21 changes: 11 additions & 10 deletions Modules/_winapi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ typedef struct {
Py_buffer write_buffer;
} OverlappedObject;

/*
Note: tp_clear (overlapped_clear) is not implemented because it
requires cancelling the IO operation if it's pending and the cancellation is
quite complex and can fail (see: overlapped_dealloc).
*/
static int
overlapped_traverse(OverlappedObject *self, visitproc visit, void *arg)
{
Expand Down Expand Up @@ -2058,29 +2063,25 @@ static PyModuleDef_Slot winapi_slots[] = {
};

static int
winapi_traverse(PyObject *m, visitproc visit, void *arg)
winapi_traverse(PyObject *module, visitproc visit, void *arg)
{
WinApiState *st = winapi_get_state(m);

WinApiState *st = winapi_get_state(module);
Py_VISIT(st->overlapped_type);

return 0;
}

static int
winapi_clear(PyObject *m)
winapi_clear(PyObject *module)
{
WinApiState *st = winapi_get_state(m);

WinApiState *st = winapi_get_state(module);
Py_CLEAR(st->overlapped_type);

return 0;
}

static void
winapi_free(void *m)
winapi_free(void *module)
{
winapi_clear((PyObject *)m);
winapi_clear((PyObject *)module);
}

static struct PyModuleDef winapi_module = {
Expand Down
0