8000 Remove duplicate address in CommonTestMixin_v4.test_leading_zeros(). by felixxm · Pull Request #26326 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Remove duplicate address in CommonTestMixin_v4.test_leading_zeros(). #26326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2021
Merged

Remove duplicate address in CommonTestMixin_v4.test_leading_zeros(). #26326

merged 1 commit into from
Jun 2, 2021

Conversation

felixxm
Copy link
Contributor
@felixxm felixxm commented May 24, 2021 •
edited by miss-islington
Loading

The same as in

cpython/Lib/test/test_ipaddress.py

Line 103 in 3ad101b

"192.168.000.001",

Automerge-Triggered-By: GH:pablogsal

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels May 24, 2021
@erlend-aasland erlend-aasland requested a review from tiran May 25, 2021 08:01
@erlend-aasland
Copy link
Contributor

@pablogsal I'm applying skip issue to this; let me know if that's impropriate.

@pablogsal
Copy link
Member

Thanks for the PR @felixxm and thanks @erlend-aasland for the review!

@felixxm
Copy link
Contributor Author
felixxm commented May 25, 2021

Thanks both 👍

@pablogsal
Copy link
Member

@Mariatta Seems that the automerge label is not working on this PR :(

@pablogsal pablogsal merged commit 1a8c778 into python:main Jun 2, 2021
@felixxm felixxm deleted the redundant-testcase branch June 2, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@felixxm @erlend-aasland @pablogsal @the-knights-who-say-ni @bedevere-bot
0