8000 bpo-44145: Release the GIL around HMAC_Update. by gpshead · Pull Request #26157 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

bpo-44145: Release the GIL arou 8000 nd HMAC_Update. #26157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2021

Conversation

gpshead
Copy link
Member
@gpshead gpshead commented May 16, 2021

It was always meant to be released for parallelization.
Thanks michaelforney for noticing.

https://bugs.python.org/issue44145

Automerge-Triggered-By: GH:gpshead

It was always meant to be released for parallelization.
Thanks michaelforney for noticing.
@gpshead gpshead added type-bug An unexpected behavior, bug, or error performance Performance or resource usage needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels May 16, 2021
@gpshead gpshead requested a review from tiran May 16, 2021 07:03
@gpshead gpshead closed this May 16, 2021
@gpshead gpshead reopened this May 16, 2021
@gpshead gpshead closed this May 16, 2021
@gpshead gpshead reopened this May 16, 2021
@tiran
Copy link
Member
tiran commented May 16, 2021

Is github having issues?

  remote: Internal Server Error.
  remote: 
  Error: fatal: unable to access 'python/cpython': The requested URL returned error: 500
  The process '/usr/bin/git' failed with exit code 128

@tiran tiran closed this May 16, 2021
@tiran tiran reopened this May 16, 2021
@Fidget-Spinner
Copy link
Member

Is github having issues?

  remote: Internal Server Error.
  remote: 
  Error: fatal: unable to access 'python/cpython': The requested URL returned error: 500
  The process '/usr/bin/git' failed with exit code 128

Yes GH actions seems to have problems: https://www.githubstatus.com/incidents/zbpwygxwb3gw

@gpshead gpshead closed this May 16, 2021
@gpshead gpshead reopened this May 16, 2021
@gpshead gpshead merged commit c10392e into python:main May 17, 2021
@miss-islington
Copy link
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@gpshead gpshead deleted the hmac-update-gil-release branch May 17, 2021 07:35
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 17, 2021
It was always meant to be released for parallelization.
This now matches the other similar code in the module.

Thanks michaelforney for noticing!
(cherry picked from commit c10392e)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot
Copy link

GH-26187 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed needs backport to 3.10 only security fixes needs backport to 3.9 only security fixes labels May 17, 2021
@bedevere-bot
Copy link

GH-26188 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 17, 2021
It was always meant to be released for parallelization.
This now matches the other similar code in the module.

Thanks michaelforney for noticing!
(cherry picked from commit c10392e)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington added a commit that referenced this pull request May 17, 2021
It was always meant to be released for parallelization.
This now matches the other similar code in the module.

Thanks michaelforney for noticing!
(cherry picked from commit c10392e)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington added a commit that referenced this pull request May 17, 2021
…6188)

It was always meant to be released for parallelization.
This now matches the other similar code in the module.

Thanks michaelforney for noticing!
(cherry picked from commit c10392e)


Co-authored-by: Gregory P. Smith <greg@krypto.org>

Automerge-Triggered-By: GH:gpshead
stratakis pushed a commit to stratakis/cpython that referenced this pull request Aug 5, 2021
It was always meant to be released for parallelization.
This now matches the other similar code in the module.

Thanks michaelforney for noticing!
(cherry picked from commit c10392e)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance or resource usage type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0