8000 [3.10] bpo-43933: Force RETURN_VALUE bytecodes to have line numbers by markshannon · Pull Request #26061 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.10] bpo-43933: Force RETURN_VALUE bytecodes to have line numbers #26061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2021
Merged

[3.10] bpo-43933: Force RETURN_VALUE bytecodes to have line numbers #26061

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23a5a31
Guarantee that line number is set for returns.
markshannon May 12, 2021
b89dd60
Add test for linenumber of return in nested try statements.
markshannon May 10, 2021
2a34a68
Remove misleading comment
markshannon May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove misleading comment
  • Loading branch information
@markshannon
markshannon committed May 12, 2021
commit 2a34a68d184dcbd79a13213308e82348765abdd5
2 changes: 0 additions & 2 deletions Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6974,8 +6974,6 @@ guarantee_lineno_for_exits(struct assembler *a, int firstlineno) {
}
struct instr *last = &b->b_instr[b->b_iused-1];
if (last->i_lineno < 0) {
/* A return in a block by itself can't have a linenumber, or
* we can mess up frame.setlineno */
if (last->i_opcode == RETURN_VALUE)
{
for (int i = 0; i < b->b_iused; i++) {
Expand Down
0