-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-44108: normalise SQL quoted literals in sqlite3 test suite #26032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@corona10 Regarding backporting, I'd say backport only to 3.10. EDIT: possibly backport to 3.10. |
@erlend-aasland Go a head :) |
I've changed my mind! :) This should be mentioned with a NEWS item: after this PR, the sqlite3 test suite will now be compatible with SQLite libraries compiled with |
We often don't add NEWS with test change but if this is a special case please let me know. |
Hm, ok. The average user is of course not expected to run the CPython test suite with a self-compiled SQLite library. I'm just thinking something like "The sqlite3 module n 8000 ow supports SQLite libraries compiled with SQLITE_DQS=0". |
@berkerpeksag what's your opinion on this? |
CPython already supports |
Yeah, that's correct. I guess it's no NEWS then. |
@erlend-aasland |
I'll check when I'm back on my computer, but I'll bet that the test we are adjusting has been there since before 3.8. Note that Miss Islington might fail to automatically backport to 3.9 and 3.8 (we normalised the test case names in 3.10). But I wouldn't backport to 3.8. At most 3.9. |
if failed please submit the manual backport patch.
3.8 is security only status. |
Thanks @erlend-aasland for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
Sorry, @erlend-aasland and @corona10, I could not cleanly backport this to |
GH-26125 is a backport of this pull request to the 3.10 branch. |
(cherry picked from commit be7e467) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Of course :) I'll do it when I'm back on my computer.
Exactly :) Thanks for helping me sorting out the NEWS & backport issues, Dong-hee! |
(cherry picked from commit be7e467) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
GH-26128 is a backport of this pull request to the 3.9 branch. |
This makes the sqlite3 test suite compatible with SQLite libraries compiled
with SQLITE_DQS=0 defined.
See also:
https://bugs.python.org/issue44108