bpo-23750: Document os-system, subprocess. Patch by Martin Panter. #26016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fidget-Spinner
approved these changes
May 10, 2021
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
orsenthil
reviewed
May 11, 2021
| * The :func:`call` return value is encoded differently to that of | ||
| :func:`os.system`. | ||
|
|
||
| * The :func:`os.system` function ignores SIGINT and SIGQUIT signals while |
There was a problem hiding this comment.
Excellent. 👍 The bug report used the term "blocked", the correct behavior is "ignored".
Ref - https://man7.org/linux/man-pages/man3/system.3.html
|
Thanks @uniocto for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 11, 2021
…ythonGH-26016) * Document os-system, subprocess Patch * Update Doc/library/os.rst Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> (cherry picked from commit 5f2eb87) Co-authored-by: uniocto <serit142sa33go@gmail.com>
|
GH-26040 is a backport of this pull request to the 3.10 branch. |
|
GH-26041 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 11, 2021
…ythonGH-26016) * Document os-system, subprocess Patch * Update Doc/library/os.rst Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> (cherry picked from commit 5f2eb87) Co-authored-by: uniocto <serit142sa33go@gmail.com>
orsenthil
pushed a commit
that referenced
this pull request
May 11, 2021
…H-26016) (GH-26040) * Document os-system, subprocess Patch * Update Doc/library/os.rst Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> (cherry picked from commit 5f2eb87) Co-authored-by: uniocto <serit142sa33go@gmail.com> Co-authored-by: uniocto <serit142sa33go@gmail.com>
orsenthil
pushed a commit
that referenced
this pull request
May 11, 2021
…H-26016) (GH-26041) * Document os-system, subprocess Patch * Update Doc/library/os.rst Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> (cherry picked from commit 5f2eb87) Co-authored-by: uniocto <serit142sa33go@gmail.com> Co-authored-by: uniocto <serit142sa33go@gmail.com>
|
@uniocto congrats on your first pull request getting merged into CPython! Welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue23750