bpo-44060: Enable TARGET labels even when not using computed gotos. #25949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realize that enabling the more featureful TARGET macro without computed gotos generates compiler warnings. I'm open to suggestions for how to suppress them. |
…a debug version of the interpreter.
|
Did you ever get this to compile without warnings? |
|
This PR is stale because it has been open for 30 days with no activity. |
Nope. But I didn't really try too hard (read: not at all)... I'll try to get this to merge cleanly again, then see about warnings... |
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Oct 14, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Oct 16, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Oct 16, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Oct 16, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Oct 17, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Oct 17, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Oct 18, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Oct 18, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Oct 19, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Oct 19, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Oct 20, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Oct 21, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Oct 21, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Nov 1, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Nov 1, 2022
|
To fix the conflict, I believe the stuff between #ifdef Py_STATS
#define INSTRUCTION_START(op) \
do { \
frame->prev_instr = next_instr++; \
OPCODE_EXE_INC(op); \
if (_py_stats) _py_stats->opcode_stats[lastopcode].pair_count[op]++; \
lastopcode = op; \
} while (0)
#else
#define INSTRUCTION_START(op) (frame->prev_instr = next_instr++)
#endif
#if USE_COMPUTED_GOTOS || defined(Py_DEBUG)
#define TARGET(op) op: TARGET_##op
#else
#define TARGET(op) op
#endif
#if USE_COMPUTED_GOTOS
#define DISPATCH_GOTO() goto *opcode_targets[opcode]
#else |
|
Thanks Terry. I deleted this and have another ready to go (which I think I
forgot about — some aspects of getting old suck...)
Skip
…On Tue, Nov 1, 2022 at 4:07 PM Terry Jan Reedy ***@***.***> wrote:
To fix the conflict, I believe the stuff between <<<<<< and >>>>>>>
should become
#ifdef Py_STATS
#define INSTRUCTION_START(op) \
do { \
frame->prev_instr = next_instr++; \
OPCODE_EXE_INC(op); \
if (_py_stats) _py_stats->opcode_stats[lastopcode].pair_count[op]++; \
lastopcode = op; \
} while (0)
#else
#define INSTRUCTION_START(op) (frame->prev_instr = next_instr++)
#endif
#if USE_COMPUTED_GOTOS || defined(Py_DEBUG)
#define TARGET(op) op: TARGET_##op
#else
#define TARGET(op) op
#endif
#if USE_COMPUTED_GOTOS
#define DISPATCH_GOTO() goto *opcode_targets[opcode]
#else
—
Reply to this email directly, view it on GitHub
<#25949 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2E3IL4HMJQ2SZOO3JOSALWGGA7LANCNFSM44HKH3KQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Nov 2, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Nov 3, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Nov 3, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Nov 3, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Nov 3, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Nov 20, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Nov 22, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Nov 22, 2022
smontanaro
added a commit
to smontanaro/cpython
that referenced
this pull request
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the TARGET_##op labels even when computed gotos aren't enabled. That generates a bunch of compiler warnings, but the labels allow gdb to break on them.
https://bugs.python.org/issue44060