8000 bpo-10379: deprecate locale.format in lieu of locale.format_string by plusminushalf · Pull Request #259 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-10379: deprecate locale.format in lieu of locale.format_string #259

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 28, 2017
Merged

bpo-10379: deprecate locale.format in lieu of locale.format_string #259

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d0f9863
bpo-10379: deprecate locale.format in lue of locale.format_string
plusminushalf Feb 23, 2017
820e289
Adding tests and documentation changes
plusminushalf Feb 24, 2017
4cfd737
Adding version changed info for locale.format
plusminushalf Feb 24, 2017
a08419f
Deprecating but not changing the function defination
plusminushalf Feb 24, 2017
4e24a3f
Adding documentation inside what's new in 3.7
plusminushalf Feb 25, 2017
6097e47
Adding whatsnew documentation in proper segments
plusminushalf Feb 27, 2017
04577c2
Merge branch 'master' of github.com:python/cpython into fix-bpo-10379
plusminushalf Feb 27, 2017
2039406
fixing documentation bug
plusminushalf Feb 27, 2017
5b100b8
Adding locale subsection
plusminushalf Feb 27, 2017
041349f
Merge branch 'master' of github.com:python/cpython into fix-bpo-10379
plusminushalf Mar 15, 2017
795aa65
Refactoring Doc, using _format inisde locale module
plusminushalf Mar 19, 2017
8190fa9
Adding entry to Misc/NEWS about changes
plusminushalf Mar 28, 2017
7e0bfcf
CR fixes
plusminushalf Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-10379: deprecate locale.format in lue of locale.format_string
  • Loading branch information
@plusminushalf
plusminushalf committed Feb 23, 2017
commit d0f986349378d8b71a46e5d16ab9bbb08f75cbf9
20 changes: 9 additions & 11 deletions Lib/locale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import collections
from builtins import str as _builtin_str
import functools
import warnings

# Try importing the _locale module.
#
Expand Down Expand Up @@ -181,17 +182,14 @@ def _strip_padding(s, amount):
r'(?P<modifiers>[-#0-9 +*.hlL]*?)[eEfFgGdiouxXcrs%]')

def format(percent, value, grouping=False, monetary=False, *additional):
"""Returns the locale-aware substitution of a %? specifier
(percent).

additional is for format strings which contain one or more
'*' modifiers."""
# this is only for one-percent-specifier strings and this should be checked
match = _percent_re.match(percent)
if not match or len(match.group())!= len(percent):
raise ValueError(("format() must be given exactly one %%char "
"format specifier, %s not valid") % repr(percent))
return _format(percent, value, grouping, monetary, *additional)
"""Deprecated, use format_string instead."""
warnings.warn(
"This method will be removed in future versions. "
"Use 'locale.format_string()' instead.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should read "This method will be removed in a future version of Python."

DeprecationWarning, stacklevel=2
)

return format_string(percent, value, grouping)

def _format(percent, value, grouping=False, monetary=False, *additional):
if additional:
Expand Down
0