8000 bpo-43984: Update winreg.SetValueEx to make sure the value set is not -1 by shreyanavigyan · Pull Request #25775 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-43984: Update winreg.SetValueEx to make sure the value set is not -1 #25775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Dec 9, 2022
Merged

bpo-43984: Update winreg.SetValueEx to make sure the value set is not -1 #25775

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
1f2d523
Fix for bpo-43984
shreyanavigyan May 1, 2021
b00fc84
Update - Free retDataBuf before returning FALSE
shreyanavigyan May 2, 2021
7841714
Update winreg.c
shreyanavigyan May 2, 2021
1123340
Add news entry
shreyanavigyan May 2, 2021
7bbb3f2
Move the error check up before allocation
shreyanavigyan May 8, 2021
c5755dd
Update 2021-05-02-15-29-33.bpo-43984.U92jiv.rst
shreyanavigyan May 8, 2021
ad67138
Update PC/winreg.c
shreyanavigyan May 8, 2021
ec0ea5a
Update PC/winreg.c
shreyanavigyan May 8, 2021
62541b8
Add test
shreyanavigyan May 8, 2021
27b8130
Fix typo
shreyanavigyan May 8, 2021
41a70e0
Update 2021-05-02-15-29-33.bpo-43984.U92jiv.rst
shreyanavigyan May 8, 2021
26b1af4
Update Lib/test/test_winreg.py
shreyanavigyan May 8, 2021
3fe16ef
Update winreg.c
shreyanavigyan May 9, 2021
dbe8651
Add test case for REG_QWORD
shreyanavigyan May 9, 2021
1d5df04
Update 2021-05-02-15-29-33.bpo-43984.U92jiv.rst
shreyanavigyan May 9, 2021
666742c
Merge branch 'main' into bpo-43984
iritkatriel Dec 8, 2022
afdee9f
Fix whitespace
AlexWaygood Dec 9, 2022
06da229
Never edit on your phone
AlexWaygood Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update winreg.c
  • Loading branch information
@shreyanavigyan
shreyanavigyan committed May 2, 2021
commit 78417143294ff843d58dd61d1fb7e190227566b5
4 changes: 2 additions & 2 deletions PC/winreg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ Py2Reg(PyObject *value, DWORD typ, BYTE **retDataBuf, DWORD *retDataSize)
else {
DWORD d = PyLong_AsUnsignedLong(value);
if ((d == (DWORD)(-1)) && PyErr_Occurred()) {
free(retDataBuf);
PyMem_Free(retDataBuf);
return FALSE;
}
memcpy(*retDataBuf, &d, sizeof(DWORD));
Expand All @@ -602,7 +602,7 @@ Py2Reg(PyObject *value, DWORD typ, BYTE **retDataBuf, DWORD *retDataSize)
else {
DWORD64 d = PyLong_AsUnsignedLongLong(value);
if ((d == (DWORD64)(-1)) && PyErr_Occurred()) {
free(retDataBuf);
PyMem_Free(retDataBuf);
return FALSE;
}
memcpy(*retDataBuf, &d, sizeof(DWORD64));
Expand Down
0