gh-87969: Amend docs and docstrings for ctypes.string_at and ctypes.wstring_at #25384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFY00
approved these changes
May 13, 2021
|
This PR is stale because it has been open for 30 days with no activity. |
|
Friendly Ping |
8000
|
@iritkatriel would you mind having a look? This is fairly straightforward, currently the documentation is wrong and does not correctly represent the code. This should probably also get backported to older versions. |
iritkatriel
reviewed
Jun 14, 2021
Misc/NEWS.d/next/Library/2021-04-13-14-58-53.bpo-43803.U_EAv6.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
I've cleaned up the PR, and addressed Irit's remark about Eryc's remark. I consider it ok to land this, so I'm enabling auto-merge. |
erlend-aasland
approved these changes
Jun 22, 2023
|
Thanks @shreyanavigyan for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 18, 2024
…pes' [w]string_at() (pythonGH-25384) The implementation uses 'ptr' for the name of the first parameter of ctypes.st 8000 ring_at() and ctypes.wstring_at(). Align docs and docstrings with the naming used in the implementation. (cherry picked from commit 81a926b) Co-authored-by: Shreyan Avigyan <shreyan.avigyan@gmail.com> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
|
GH-118046 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 18, 2024
…pes' [w]string_at() (pythonGH-25384) The implementation uses 'ptr' for the name of the first parameter of ctypes.string_at() and ctypes.wstring_at(). Align docs and docstrings with the naming used in the implementation. (cherry picked from commit 81a926b) Co-authored-by: Shreyan Avigyan <shreyan.avigyan@gmail.com> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
|
GH-118047 is a backport of this pull request to the 3.11 branch. |
encukou
pushed a commit
that referenced
this pull request
Apr 19, 2024
…ypes' [w]string_at() (GH-25384) (GH-118046) gh-87969: Align docs and docstrings with implementation for ctypes' [w]string_at() (GH-25384) The implementation uses 'ptr' for the name of the first parameter of ctypes.string_at() and ctypes.wstring_at(). Align docs and docstrings with the naming used in the implementation. (cherry picked from commit 81a926b) Co-authored-by: Shreyan Avigyan <shreyan.avigyan@gmail.com> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docstrings, docs and argument lists of the functions ctypes.string_at and ctypes.wstring_at used different names to refer to the first argument. Changing them to only use the name "ptr" to refer to the first argument.
https://bugs.python.org/issue43803