8000 [3.8] bpo-43075: Fix ReDoS in urllib AbstractBasicAuthHandler (GH-24391) by miss-islington · Pull Request #25248 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.8] bpo-43075: Fix ReDoS in urllib AbstractBasicAuthHandler (GH-24391) #25248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2021
Merged

[3.8] bpo-43075: Fix ReDoS in urllib AbstractBasicAuthHandler (GH-24391) #25248

merged 1 commit into from
Apr 7, 2021

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Apr 7, 2021 •
edited by bedevere-bot
Loading

Fix Regular Expression Denial of Service (ReDoS) vulnerability in
urllib.request.AbstractBasicAuthHandler. The ReDoS-vulnerable regex
has quadratic worst-case complexity and it allows cause a denial of
service when identifying crafted invalid RFCs. This ReDoS issue is on
the client side and needs remote attackers to control the HTTP server.
(cherry picked from commit 7215d1a)

Co-authored-by: Yeting Li liyt@ios.ac.cn

https://bugs.python.org/issue43075

@yetingli @miss-islington
bpo-43075: Fix ReDoS in urllib AbstractBasicAuthHandler (pythonGH-24391)
660e362 
Fix Regular Expression Denial of Service (ReDoS) vulnerability in
urllib.request.AbstractBasicAuthHandler. The ReDoS-vulnerable regex
has quadratic worst-case complexity and it allows cause a denial of
service when identifying crafted invalid RFCs. This ReDoS issue is on
the client side and needs remote attackers to control the HTTP server.
(cherry picked from commit 7215d1a)

Co-authored-by: Yeting Li <liyt@ios.ac.cn>
@bedevere-bot bedevere-bot mentioned this pull request Apr 7, 2021
Merged
@miss-islington
Copy link
Contributor Author

@yetingli and @vstinner: Status check is done, and it's a success ✅ .

vstinner
vstinner approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@yetingli and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit e7654b6 into python:3.8 Apr 7, 2021
@miss-islington miss-islington deleted the backport-7215d1a-3.8 branch April 7, 2021 11:45
@yetingli yetingli mannequin mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @yetingli
0