-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
bpo-43574: Dont overallocate list literals #24954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
chadnetzer
wants to merge
11
commits into
python:main
from
chadnetzer:bpo43574-dont-overallocate-list-literals
Closed
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4dbee9a
Add testcase for bpo-43574 list overallocaton
chadnetzer 5b31470
Don't overallocate when extending an empty list
chadnetzer 172f2c0
Skip overallocation calc when not overallocating
chadnetzer d76ae2a
Fix list_extend() init list changes to PEP-7 form
chadnetzer 7aad246
bpo-43574: Add NEWS
chadnetzer 7c20c6c
Add more list overallocation regression tests
chadnetzer 7be3ae8
Put common-case first in logical-or list_resize()
chadnetzer 7436223
Adjust NEWS entry language based on PR feedback
chadnetzer 657d51f
Allow empty list append/insert to overallocate
chadnetzer 4336cc6
Update test_overallocation of empty list append()
chadnetzer 19d4374
Add direct test of list-literal non-overallocation
chadnetzer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Core and Builtins/2021-03-21-18-51-30.bpo-43574.mteI-I.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Restores previous list memory behavior where lists initialized from literals | ||
aren't over-allocated. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.