8000 [3.9] bpo-43423 Fix IndexError in subprocess _communicate function (GH-24777) by miss-islington · Pull Request #24831 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.9] bpo-43423 Fix IndexError in subprocess _communicate function (GH-24777) #24831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2021
Merged

[3.9] bpo-43423 Fix IndexError in subprocess _communicate function (GH-24777) #24831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-43423 Fix IndexError in subprocess _communicate function (GH-24777) 
Check to make sure stdout and stderr are not empty before selecting an item from them in Windows subprocess._communicate.

Co-authored-by: Gregory P. Smith <greg@krypto.org>
(cherry picked from commit b4fc44b)

Co-authored-by: Chris Griffith <chris@cdgriffith.com>
  • Loading branch information
@cdgriffith @miss-islington
cdgriffith authored and miss-islington committed Mar 12, 2021
commit 2ddab7b8a8606d3791d57f9f90ee891735cd8ec9
6 changes: 2 additions & 4 deletions Lib/subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1525,10 +1525,8 @@ def _communicate(self, input, endtime, orig_timeout):
self.stderr.close()

# All data exchanged. Translate lists into strings.
if stdout is not None:
stdout = stdout[0]
if stderr is not None:
stderr = stderr[0]
stdout = stdout[0] if stdout else None
stderr = stderr[0] if stderr else None

return (stdout, stderr)

Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2021-03-11-15-44-18.bpo-43423.rRomRD.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
:func:`subprocess.communicate` no longer raises an IndexError when there is an
empty stdout or stderr IO buffer during a timeout on Windows.
0