8000 bpo-43479: Remove a duplicate comment and assignment in http.client by geryogam · Pull Request #24827 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-43479: Remove a duplicate comment and assignment in http.client #24827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2021
Merged

bpo-43479: Remove a duplicate comment and assignment in http.client #24827

merged 1 commit into from
Mar 13, 2021

Conversation

geryogam
Copy link
Contributor
@geryogam geryogam commented Mar 11, 2021 •
edited by bedevere-bot
Loading

Remove a duplicate comment and assignment in the http.client standard library.

https://bugs.python.org/issue43479

@geryogam geryogam changed the title Remove a duplicate comment and assignment in http.client bpo-43479: Remove a duplicate comment and assignment in http.client Mar 12, 2021
orsenthil
orsenthil approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member
@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-) wow, for 12 years.

@orsenthil orsenthil merged commit b6884ad into python:master Mar 13, 2021
@miss-islington
Copy link
Contributor

Thanks @maggyero for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @maggyero for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 13, 2021
@geryogam @miss-islington
Update client.py (pythonGH-24827)
a96c60d 
(cherry picked from commit b6884ad)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 13, 2021
@bedevere-bot
Copy link

GH-24839 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 13, 2021
@geryogam @miss-islington
Update client.py (pythonGH-24827)
5433b23 
(cherry picked from commit b6884ad)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@bedevere-bot
Copy link

GH-24840 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Mar 13, 2021
@miss-islington @geryogam
Update client.py (GH-24827)
53ab4af 
(cherry picked from commit b6884ad)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
miss-islington added a commit that referenced this pull request Mar 13, 2021
@miss-islington @geryogam
Update client.py (GH-24827)
9f935fa 
(cherry picked from commit b6884ad)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@geryogam geryogam deleted the patch-14 branch March 13, 2021 14:53
@geryogam
Copy link
Contributor Author

Thank you @orsenthil!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil orsenthil approved these changes

Assignees
No one assigned
Labels
awaiting merge skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@geryogam @miss-islington @bedevere-bot @orsenthil @the-knights-who-say-ni
0