8000 [3.8] bpo-43423: Fix IndexError in subprocess _communicate function (GH-24777) by miss-islington · Pull Request #24824 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.8] bpo-43423: Fix IndexError in subprocess _communicate function (GH-24777) #24824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.8] bpo-43423: Fix IndexError in subprocess _communicate function (GH-24777) #24824

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Mar 11, 2021 •
edited
Loading

Check to make sure stdout and stderr are not empty before selecting an item from them in Windows subprocess._communicate.

Co-authored-by: Gregory P. Smith greg@krypto.org
(cherry picked from commit b4fc44b)

Co-authored-by: Chris Griffith chris@cdgriffith.com

https://bugs.python.org/issue43423

Automerge-Triggered-By: GH:gpshead

@cdgriffith @miss-islington
bpo-43423 Fix IndexError in subprocess _communicate function (pythonG…
6270a31 
…H-24777)

Check to make sure stdout and stderr are not empty before selecting an item from them in Windows subprocess._communicate.

Co-authored-by: Gregory P. Smith <greg@krypto.org>
(cherry picked from commit b4fc44b)

Co-authored-by: Chris Griffith <chris@cdgriffith.com>
@miss-islington miss-islington requested a review from gpshead as a code owner March 11, 2021 19:44
@bedevere-bot bedevere-bot mentioned this pull request Mar 11, 2021
Merged
@gpshead gpshead added 🤖 automerge type-bug An unexpected behavior, bug, or error labels Mar 11, 2021
@miss-islington
Copy link
Contributor Author

@cdgriffith and @gpshead: Status check is done, and it's a success ✅ .

@gpshead gpshead changed the title [3.8] bpo-43423 Fix IndexError in subprocess _communicate function (GH-24777) [3.8] bpo-43423: Fix IndexError in subprocess _communicate function (GH-24777) Mar 12, 2021
@miss-islington
Copy link
Contributor Author

@cdgriffith and @gpshead: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@cdgriffith and @gpshead: Status check is done, and it's a success ✅ .

@gpshead gpshead closed this Mar 12, 2021
@miss-islington miss-islington deleted the backport-b4fc44b-3.8 branch March 12, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
awaiting merge type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @gpshead @bedevere-bot @cdgriffith
0