8000 bpo-43232: Prohibit previously deprecated operations on TransportSocket by illia-v · Pull Request #24538 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

bpo-43232: Prohibit previously deprecated operations on TransportSocket #24538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Drop all banned methods of TransportSocket
  • Loading branch information
illia-v committed Jun 29, 2021
commit 1f3d532941059bd9c394a9c51b736e8ca7e739a7
81 changes: 0 additions & 81 deletions Lib/asyncio/trsock.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,6 @@ class TransportSocket:
def __init__(self, sock: socket.socket):
self._sock = sock

@staticmethod
def _na(what):
raise RuntimeError(
f"Using {what} on sockets returned from get_extra_info('socket') "
f"is prohibited.")

@property
def family(self):
return self._sock.family
Expand Down Expand Up @@ -88,75 +82,6 @@ def getsockname(self):
def getsockbyname(self):
return self._sock.getsockbyname()

def accept(self):
self._na('accept() method')

def connect(self, *args, **kwargs):
self._na('connect() method')

def connect_ex(self, *args, **kwargs):
self._na('connect_ex() method')

def bind(self, *args, **kwargs):
self._na('bind() method')

def ioctl(self, *args, **kwargs):
self._na('ioctl() method')

def listen(self, *args, **kwargs):
self._na('listen() method')

def makefile(self):
self._na('makefile() method')

def sendfile(self, *args, **kwargs):
self._na('sendfile() method')

def close(self):
self._na('close() method')

def detach(self):
self._na('detach() method')

def sendmsg_afalg(self, *args, **kwargs):
self._na('sendmsg_afalg() method')

def sendmsg(self, *args, **kwargs):
self._na('sendmsg() method')

def sendto(self, *args, **kwargs):
self._na('sendto() method')

def send(self, *args, **kwargs):
self._na('send() method')

def sendall(self, *args, **kwargs):
self._na('sendall() method')

def set_inheritable(self, *args, **kwargs):
self._na('set_inheritable() method')

def share(self, process_id):
self._na('share() method')

def recv_into(self, *args, **kwargs):
self._na('recv_into() method')

def recvfrom_into(self, *args, **kwargs):
self._na('recvfrom_into() method')

def recvmsg_into(self, *args, **kwargs):
self._na('recvmsg_into() method')

def recvmsg(self, *args, **kwargs):
self._na('recvmsg() method')

def recvfrom(self, *args, **kwargs):
self._na('recvfrom() method')

def recv(self, *args, **kwargs):
self._na('recv() method')

def settimeout(self, value):
if value == 0:
return
Expand All @@ -171,9 +96,3 @@ def setblocking(self, flag):
return
raise ValueError(
'setblocking(): transport sockets cannot be blocking')

def __enter__(self):
self._na('context manager protocol')

def __exit__(self, *err):
self._na('context manager protocol')
0