8000 Fixing typos in turtle.rst by Seluj78 · Pull Request #24385 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

Fixing typos in turtle.rst #24385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 30, 2021
Merged

Fixing typos in turtle.rst #24385

merged 5 commits into from
May 30, 2021

Conversation

Seluj78
Copy link
Contributor
@Seluj78 Seluj78 commented Jan 30, 2021

Even more typos. (I'll keep updating the PR as I find more or open new ones)

Copy link
Contributor
@serverwentdown serverwentdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor changes.

@@ -1894,7 +1894,7 @@ Input methods
Pop up a dialog window for input of a number. title is the title of the
dialog window, prompt is a text mostly describing what numerical information
to input. default: default value, minval: minimum value for input,
maxval: maximum value for input
maxval: maximum value for input.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is better rewritten as:

... *title* is the title of the dialog window, *prompt* is a text mostly describing what numerical information to input.  *default* is a default value to fill the input with. 

The number input must be in the range  *minval* .. *maxval* (inclusive) if these are given. If outside of this range, a hint is issued and the dialog remains open for correction.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 14, 2021
@nanjekyejoannah nanjekyejoannah merged commit 8ab5b7e into python:main May 30, 2021
Copy link
Contributor
@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no activity to add the requested changes, and PR went stale, I will merge as-is for now.

@serverwentdown, you can open a PR for your suggestions if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0