-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
bpo-38307: Add end_lineno attribute to pyclbr _Objects #24348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
terryjreedy
merged 35 commits into
python:master
from
kebab-mai-haddi:endline-in-readmodule-module
Feb 1, 2021
Merged
Changes from 2 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
1f25ed4
compeltes the Stack implementation to yield ending line for each class.
7d2354a
reverts whitespace and unwanted changes including functions, comments…
c8a003d
removes leftover whitespace in b/w functions: unwanted
7e6f079
Initialize stack of (class, indent) pairs.
b7c1ce7
removes Stack() custom class and adds direct attribute (end_lineno) i…
3466f63
corrects the attribute name to end_lineno and sets the same without u…
f2a58c6
removes unwanted module: inspect
94edb5b
corrects the way of setting attribute
kebab-mai-haddi 454d305
📜🤖 Added by blurb_it.
blurb-it[bot] dc0166f
wip: added end_lineno in tests
kebab-mai-haddi 5a26a5c
Merge branch 'endline-in-readmodule-module' of github.com:avisrivasta…
kebab-mai-haddi ea2090b
wip
kebab-mai-haddi 49d0695
compeltes the Stack implementation to yield ending line for each class.
33aa14c
reverts whitespace and unwanted changes including functions, comments…
2f9579a
removes leftover whitespace in b/w functions: unwanted
668fe22
wip: added end_lineno in tests
kebab-mai-haddi efb49ea
📜🤖 Added by blurb_it.
blurb-it[bot] 963b783
wip
kebab-mai-haddi d0d0966
fixed conflicts after diverge
kebab-mai-haddi d924d4a
adds end_lineno as an attribute for Class and Functions objects
kebab-mai-haddi 78f166f
adds the news.
kebab-mai-haddi fc74ec7
adds positional arguments in the tests and end_lineno as an argument …
kebab-mai-haddi b5f29c0
removes debugging print statements.
kebab-mai-haddi f3c09fe
adds endline no in all the tests for the dummy tree"
kebab-mai-haddi 7337551
adds endline no in all the tests for the dummy tree
kebab-mai-haddi 3e8181c
Merge branch 'endline-in-readmodule-module' of github.com:kebab-mai-h…
kebab-mai-haddi 77784e3
Update 2020-03-16-03-03-21.bpo-38307.2cmw2i.rst
terryjreedy d73395a
Update 2020-03-16-03-03-21.bpo-38307.2cmw2i.rst
terryjreedy cc82d4f
Merge remote-tracking branch 'upstream/master' into pr_24348
terryjreedy 9238fcd
Fix end_lineno.
terryjreedy ed20fa4
Add What's New in 3.10 entry
terryjreedy 48b7341
Update Doc/whatsnew/3.10.rst
terryjreedy 9172efc
Direct calls by by keyword
terryjreedy d0ca986
blank line
terryjreedy af31c28
Merge branch 'endline-in-readmodule-module' of https://github.com/keb…
terryjreedy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
Misc/NEWS.d/next/Library/2020-03-16-03-03-21.bpo-38307.2cmw2i.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Adds end line no in class' use: generating dependency. | ||
| : `end_lineno` is added to denote the scope of a class | ||
| along with `lineno` which was already present in the codebase. | ||
| Patch by Aviral Srivastava. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can’t parse this line 🙂
(and second line starting with colon seems strange)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither could I nor the doc tests. I replaced it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @terryjreedy !
But how could you push a change to my forked repository?
(I am not objecting to it, I just do not understand how another person can push to mine repo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you made the PR, you left a checkmark in the box that says to allow core developers ('Members of Python' when you mouse over the icons) to modify the files in this branch. If you had removed it, I would have asked to put is back in if possible. To pull to your local repository, which you should do before making further changes, checkout this branch, endline-in-readmodule-module, and, I believe, if you defined 'origin' as the devguide suggests
Don't use rebase.