8000 [doc] Fix addCleanupClass -> addClassCleanup typo by Conchylicultor · Pull Request #24194 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[doc] Fix addCleanupClass -> addClassCleanup typo #24194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2021
Merged

[doc] Fix addCleanupClass -> addClassCleanup typo #24194

merged 2 commits into from
Jan 20, 2021

Conversation

Conchylicultor
Copy link
Contributor

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 11, 2021
tirkarthi
tirkarthi reviewed Jan 12, 2021
View reviewed changes
Copy link
Member
@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there is a similar typo of doCleanupsClass -> doClassCleanups in https://docs.python.org/3/library/unittest.html#unittest.TestCase.doClassCleanups

@Conchylicultor Conchylicultor changed the title [doc] Fix addCleanupClass -> addCleanupClass typo [doc] Fix addCleanupClass -> addClassCleanup typo Jan 12, 2021
@Conchylicultor
Copy link
Contributor Author

I guess there is a similar typo of doCleanupsClass -> doClassCleanups in https://docs.python.org/3/library/unittest.html#unittest.TestCase.doClassCleanups

Done

tirkarthi
tirkarthi approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member
@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@tirkarthi tirkarthi merged commit e0e398e into python:master Jan 20, 2021
@miss-islington
Copy link
Contributor

Thanks @Conchylicultor for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-24267 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

GH-24268 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2021
@Conchylicultor @miss-islington
Fix typos in unittest documentation (pythonGH-24194)
cc2852a 
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
(cherry picked from commit e0e398e)

Co-authored-by: Conchylicultor <etiennefg.pot@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2021
@Conchylicultor @miss-islington
Fix typos in unittest documentation (pythonGH-24194)
997d777 
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
(cherry picked from commit e0e398e)

Co-authored-by: Conchylicultor <etiennefg.pot@gmail.com>
miss-islington added a commit that referenced this pull request Jan 20, 2021
@miss-islington @Conchylicultor
Fix typos in unittest documentation (GH-24194)
ebb2f26 
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
(cherry picked from commit e0e398e)

Co-authored-by: Conchylicultor <etiennefg.pot@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@Conchylicultor @adorilson
Fix typos in unittest documentation (pythonGH-24194)
c4837f1 
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
miss-islington added a commit that referenced this pull request Mar 14, 2021
@miss-islington @Conchylicultor
Fix typos in unittest documentation (GH-24194)
bb46c13 
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
(cherry picked from commit e0e398e)

Co-authored-by: Conchylicultor <etiennefg.pot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@ZackerySpytz ZackerySpytz ZackerySpytz approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Conchylicultor @miss-islington @bedevere-bot @tirkarthi @ZackerySpytz @the-knights-who-say-ni
0