8000 bpo-42833: make digest algorithms case insensitive by tardyp · Pull Request #24122 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-42833: make digest algorithms case insensitive #24122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bpo-42833: make digest algorithms case insensitive #24122

wants to merge 1 commit into from
+15 −2

Conversation

tardyp
Copy link
@tardyp tardyp commented Jan 5, 2021 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@tardyp

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

tiran
tiran requested changes Jan 5, 2021
View reviewed changes
Copy link
Member
@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use SHA for testing and wrap the new test function with requires_hashdigest("sha1") decorator from test.support package.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tardyp tardyp mentioned this pull request Jan 5, 2021
Closed
@tardyp
Copy link
Author
tardyp commented Jan 5, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from tiran January 5, 2021 16:11
@tardyp
Copy link
Author
tardyp commented Jan 6, 2021

@tiran I signed the CLA and fixed the tests. It should be ready to go. thx!

@markus-sus markus-sus mentioned this pull request Jan 11, 2021
Merged
3 tasks
@github-actions
Copy link
8000 github-actions bot commented Feb 6, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 6, 2021
@tardyp
Copy link
Author
tardyp commented Apr 7, 2021

anything I need to do?

@tardyp
Copy link
Author
tardyp commented Apr 7, 2021

@tiran ping

tiran
tiran requested changes Apr 7, 2021
View reviewed changes
Copy link
Member
@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a versionchanged entry to documentation?
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tiran tiran removed the stale Stale PR or inactive for long period of time. label Apr 7, 2021
ElWeroRanchero
ElWeroRanchero approved these changes Aug 8, 2021
View reviewed changes
Copy link
@ElWeroRanchero ElWeroRanchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran requested changes

@ElWeroRanchero ElWeroRanchero ElWeroRanchero approved these changes

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tardyp @the-knights-who-say-ni @bedevere-bot @tiran @ElWeroRanchero @ezio-melotti
0