8000 bpo-41559: Convert lists to tuples in genericalias to prepare for PEP 612 by Fidget-Spinner · Pull Request #24056 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-41559: Convert lists to tuples in genericalias to prepare for PEP 612 #24056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

bpo-41559: Convert lists to tuples in genericalias to prepare for PEP 612 #24056

wants to merge 12 commits into from

Conversation

Fidget-Spinner
Copy link
Member
@Fidget-Spinner Fidget-Spinner commented Jan 2, 2021 •
edited by bedevere-bot
Loading

Needs manual backport to 3.9.

https://bugs.python.org/issue41559

ZackerySpytz
ZackerySpytz reviewed Jan 5, 2021
View reviewed changes
@Fidget-Spinner
Copy link
Member Author

@ZackerySpytz Thank you for taking the time to review this and for raising many glaring points :). I'm quite busy right now so I'll try to address them by this weekend.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 16, 2021
@Fidget-Spinner Fidget-Spinner mentioned this pull request Apr 11, 2021
Merged
@Fidget-Spinner
Copy link
Member Author
Fidget-Spinner commented Apr 17, 2021 •
edited
Loading

Closed in favour of #25449 which uses a pure Python version of PEP 612. Thus we won't need a C implementation any more.

@Fidget-Spinner Fidget-Spinner deleted the tupleify-ga branch May 16, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackerySpytz ZackerySpytz ZackerySpytz left review comments

Assignees
No one assigned
Labels
awaiting review stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fidget-Spinner @ZackerySpytz @the-knights-who-say-ni @bedevere-bot
0