8000 bpo-25479: add unit test for __subclasshook__ in test_abc.py by karlcow · Pull Request #24034 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-25479: add unit test for __subclasshook__ in test_abc.py #24034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2021
Merged

bpo-25479: add unit test for __subclasshook__ in test_abc.py #24034

merged 1 commit into from
May 12, 2021

Conversation

karlcow
Copy link
Contributor
@karlcow karlcow commented Jan 1, 2021 •
edited by miss-islington
Loading

Converted the patch previously submitted by szymon to extend the coverage of ABC tests into a github PR.
Co-authored-by: Szymon Trapp

https://bugs.python.org/issue25479

Automerge-Triggered-By: GH:iritkatriel

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 1, 2021
@karlcow
bpo-25479: Patch to increase __subclasshook__ test coverage of abc.py
17e486e 
Converted the patch previously submitted by szymon to extend the coverage of ABC tests into a github PR.
Co-authored-by: Szymon Trapp
@iritkatriel
Copy link
Member

@karlcow Thanks for the patch. A comment on process: when responding to reviews, don't squash and force-push, just push the additional commit(s). It's nice for the reviewers to be able to see the diff, particularly for more complex PRs. When the PR is merged all the commit are squashed into one, so you don't need to do this.

@github-actions
Copy link
github-actions bot commented Feb 1, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 1, 2021
@iritkatriel iritkatriel changed the title bpo-25479: Patch to increase __subclasshook__ test coverage of abc.py bpo-25479: add unit test for __subclasshook__ in test_abc.py May 12, 2021
@iritkatriel
Copy link
Member

closing and reopening to get a fresh test run

@iritkatriel iritkatriel reopened this May 12, 2021
@iritkatriel iritkatriel merged commit 5010c04 into python:main May 12, 2021
@miss-islington
Copy link
Contributor

Thanks @karlcow for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @karlcow and @iritkatriel, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 5010c044c73ee55d0fd578cfecd3f4c3f01a4140 3.10

@bedevere-bot
Copy link

GH-26063 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 12, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2021
@karlcow @miss-islington
bpo-25479: add unit test for __subclasshook__ in test_abc.py (pythonG…
a2976b7 
…H-24034)

Co-authored-by: Szymon Trapp
(cherry picked from commit 5010c04)

Co-authored-by: Karl Dubost <karl+github@la-grange.net>
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request May 12, 2021
@karlcow @iritkatriel
[3.10] bpo-25479: add unit test for __subclasshook__ in test_abc.py (p…
f16ad42 
…ythonGH-24034)

Co-authored-by: Szymon Trapp
(cherry picked from commit 5010c04)

Co-authored-by: Karl Dubost <karl+github@la-grange.net>
@iritkatriel iritkatriel mentioned this pull request May 12, 2021
Merged
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 12, 2021
@bedevere-bot
Copy link

GH-26065 is a backport of this pull request to the 3.10 branch.

iritkatriel pushed a commit that referenced this pull request May 12, 2021
@miss-islington @karlcow
bpo-25479: add unit test for __subclasshook__ in test_abc.py (GH-24034)…
1be9396 
… (GH-26063)

Co-authored-by: Szymon Trapp
(cherry picked from commit 5010c04)

Co-authored-by: Karl Dubost <karl+github@la-grange.net>
iritkatriel added a commit that referenced this pull request May 12, 2021
@iritkatriel @karlcow
[3.10] bpo-25479: add unit test for __subclasshook__ in test_abc.py (G…
bd5dfd6 
…H-24034) (GH-26065)

Co-authored-by: Szymon Trapp
(cherry picked from commit 5010c04)

Co-authored-by: Karl Dubost <karl+github@la-grange.net>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

@iritkatriel iritkatriel

Labels
skip news stale Stale PR or inactive for long period of time. tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@karlcow @iritkatriel @miss-islington @bedevere-bot @the-knights-who-say-ni
0