8000 bpo-42756: Configure LMTP Unix-domain socket to use global default timeout when timeout not provided by rrhodes · Pull Request #23969 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-42756: Configure LMTP Unix-domain socket to use global default timeout whe 8000 n timeout not provided #23969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 1, 2021
Merged

bpo-42756: Configure LMTP Unix-domain socket to use global default timeout when timeout not provided #23969

merged 10 commits into from
Jan 1, 2021

Conversation

rrhodes
Copy link
Contributor
@rrhodes rrhodes commented Dec 27, 2020 •
edited by bedevere-bot
Loading

What?

  1. Configure LMTP Unix-domain socket to use socket global default timeout when a timeout is not explicitly provided.
  2. Removed unused "int_port" from the mock socket create_connection method.

Why?

To allow users to apply the default timeout without explicitly needing to pass in None.

https://bugs.python.org/issue42756

@rrhodes rrhodes requested a review from a team as a code owner December 27, 2020 21:20
@corona10 corona10 added the needs backport to 3.9 only security fixes label Jan 1, 2021
@corona10 corona10 requested review from corona10 and vstinner January 1, 2021 06:33
corona10
corona10 requested changes Jan 1, 2021
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

corona10
corona10 reviewed Jan 1, 2021
View reviewed changes
@corona10
Copy link
Member
corona10 commented Jan 1, 2021 •
edited
Loading

@vstinner Can you please take a look also?
This PR is following what socket.create_connection doing.

cpython/Lib/socket.py

Line 827 in c8a7b8f

if timeout is not _GLOBAL_DEFAULT_TIMEOUT:

corona10
corona10 reviewed Jan 1, 2021
View reviewed changes
@rrhodes rrhodes requested review from corona10 and removed request for a team January 1, 2021 16:55
@corona10 corona10 merged commit 3bf0532 into python:master Jan 1, 2021
@miss-islington
Copy link
Contributor

Thanks @rrhodes for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @rrhodes and @corona10, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3bf05327c2b25d42b92795d9d280288c22a0963d 3.9

@corona10
Copy link
Member
corona10 commented Jan 1, 2021

@rrhodes Thank you for working on this!

@rrhodes rrhodes deleted the fix-issue-42756 branch January 1, 2021 17:21
corona10 pushed a commit to corona10/cpython that referenced this pull request Jan 1, 2021
@rrhodes @corona10
[3.9] bpo-42756: Configure LMTP Unix-domain socket to use global defa…
5c15722 
…ult timeout when timeout not provided (pythonGH-23969)

(cherry picked from commit 3bf0532)

Co-authored-by: Ross <rrhodes@users.noreply.github.com>
@corona10 corona10 mentioned this pull request Jan 1, 2021
Closed
@corona10
Copy link
Member
corona10 commented Jan 1, 2021

@rrhodes Would you like to submit the backport patch for this?

@rrhodes
Copy link
Contributor Author
rrhodes commented Jan 1, 2021

@rrhodes Would you like to submit the backport patch for this?

Sure, first time backporting so bear with me please.

@corona10
Copy link
Member
corona10 commented Jan 1, 2021

@rrhodes
Using the cherry-picker is the easy way

https://pypi.org/project/cherry-picker/#about

rrhodes added a commit to rrhodes/cpython that referenced this pull request Jan 1, 2021
@rrhodes
[3.9] bpo-42756: Configure LMTP Unix-domain socket to use global defa…
ac6b46b 
…ult timeout when timeout not provided (pythonGH-23969)

(cherry picked from commit 3bf0532)

Co-authored-by: Ross <rrhodes@users.noreply.github.com>
@rrhodes rrhodes mentioned this pull request Jan 1, 2021
Merged
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 1, 2021
@bedevere-bot
Copy link

GH-24050 is a backport of this pull request to the 3.9 branch.

corona10 pushed a commit that referenced this pull request Jan 2, 2021
@rrhodes
[3.9] bpo-42756: Configure LMTP Unix-domain socket to use global defa…
6912061 
…ult timeout when timeout not provided (GH-23969) (GH-24050)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@rrhodes @adorilson
bpo-42756: Configure LMTP Unix-domain socket to use global default ti…
9dd5ae7 
…meout when timeout not provided (pythonGH-23969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

@corona10 corona10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rrhodes @bedevere-bot @corona10 @miss-islington @the-knights-who-say-ni
0