8000 gh-82616: Add process_group support to subprocess.Popen by gpshead · Pull Request #23930 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-82616: Add process_group support to subprocess.Popen #23930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 5, 2022
Merged

gh-82616: Add process_group support to subprocess.Popen #23930

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
1454088
Add setpgid support to subprocess.POpen
gpshead Dec 25, 2020
6aad6e3
Fix compilation error.
gpshead Dec 25, 2020
5f5d800
Fix the fork_exec() calls. tests pass.
gpshead Dec 25, 2020
010ae9a
Fix multiprocessing's _posixsubprocess.fork_exec() call.
gpshead Dec 25, 2020
8a770ab
Fix test_capi.
gpshead Dec 25, 2020
645256e
Merge branch 'main' into subprocess-issue38435
gpshead May 5, 2022
b58758b
Add missing \ in Doc/library/subprocess.rst
gpshead May 5, 2022
acba394
better ReST in Doc/library/subprocess.rst
gpshead May 5, 2022
cef3bbe
improve formatting in Doc/library/subprocess.rst
gpshead May 5, 2022
e594a01
improve formatting in Doc/library/subprocess.rst
gpshead May 5, 2022
ab9f0a5
better formatting
gpshead May 5, 2022
3b3a5d0
versionadded 3.11
gpshead May 5, 2022
20a1363
Rename from setpgid to process_group
gpshead May 5, 2022
3df5b30
test_capi: update its internal call
gpshead May 5, 2022
450e87d
Merge branch 'main' into subprocess-issue38435
gpshead May 5, 2022
8000
44cc293
blindly attempting to appease an ASAN bug.
gpshead May 5, 2022
9d48704
Merge branch 'subprocess-issue38435' of github.com:gpshead/cpython in…
gpshead May 5, 2022
bb9461b
Disable the tests exposing ASAN flakiness.
gpshead May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into subprocess-issue38435
  • Loading branch information
@gpshead
gpshead authored May 5, 2022
commit 645256e3cc5f023d5679dc66a58881f5c872ef28
3 changes: 2 additions & 1 deletion Lib/multiprocessing/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,8 @@ def spawnv_passfds(path, args, passfds):
return _posixsubprocess.fork_exec(
args, [path], True, passfds, None, None,
-1, -1, -1, -1, -1, -1, errpipe_read, errpipe_write,
False, False, -1, None, None, None, -1, None)
False, False, -1, None, None, None, -1, None,
subprocess._USE_VFORK)
finally:
os.close(errpipe_read)
os.close(errpipe_write)
Expand Down
2 changes: 1 addition & 1 deletion Lib/subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1817,7 +1817,7 @@ def _execute_child(self, args, executable, preexec_fn, close_fds,
errpipe_read, errpipe_write,
restore_signals, start_new_session,
setpgid, gid, gids, uid, umask,
preexec_fn)
preexec_fn, _USE_VFORK)
self._child_created = True
finally:
# be sure the FD is closed no matter what
Expand Down
2 changes: 1 addition & 1 deletion Modules/_posixsubprocess.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@ subprocess_fork_exec(PyObject *module, PyObject *args)
int allow_vfork;

if (!PyArg_ParseTuple(
args, "OOpO!OOiiiiiiiiii" _Py_PARSE_PID "OOOiO:fork_exec",
args, "OOpO!OOiiiiiiiiii" _Py_PARSE_PID "OOOiOp:fork_exec",
&process_args, &executable_list,
&close_fds, &PyTuple_Type, &py_fds_to_keep,
&cwd_obj, &env_list,
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.
0